New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3151: Don't make associations for NRS2 IFU if detector not illuminated #8395
Conversation
Add requirement that no spec2 associations are made for NRS IFU settings that don't illuminate the NRS2 detector Fix test that made such an association
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8395 +/- ##
==========================================
+ Coverage 75.31% 75.78% +0.47%
==========================================
Files 474 476 +2
Lines 38965 39450 +485
==========================================
+ Hits 29345 29897 +552
+ Misses 9620 9553 -67
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Of the 3 association-related failures in the regtest, it's not obvious from the logs whether the changes are expected due to this update. Can you confirm? |
The 3 regression test failures in the developer PR test above are all because the truth files have NRS_IFU spec2 associations where there is no data on nrs2, so the PR code doesn't make them. |
Great. So in that case, I hereby approve this PR. ;-) |
Filter dupes in mkpool.
Add requirement that no spec2 associations are made for NRS IFU settings that don't illuminate the NRS2 detector
Fix test that made such an association
Resolves JP-3151
Closes #7775
This PR addresses remaining issues with this ticket: only data with PATTTYPE with NODs, plus imprint and background exposures was being handled properly, but not all other types. In this PR, all spec2 associations check whether the nrs2 detector is illuminated before creating an association.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR