-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3102: NIRSpec combined MOS/FS processing #8467
base: master
Are you sure you want to change the base?
JP-3102: NIRSpec combined MOS/FS processing #8467
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8467 +/- ##
==========================================
+ Coverage 58.02% 59.01% +0.98%
==========================================
Files 388 388
Lines 38977 39136 +159
==========================================
+ Hits 22617 23095 +478
+ Misses 16360 16041 -319 ☔ View full report in Codecov by Sentry. |
6d6fc0a
to
0e75426
Compare
31897e1
to
8dce641
Compare
ddaf8d7
to
d06baa7
Compare
e98b3a7
to
8429797
Compare
56dd6b5
to
cc14cfe
Compare
…ithout MSA file source definition
1fbc557
to
52359a0
Compare
@hbushouse @hayescr - I think this is ready for an initial code review. I will leave it at draft status because I still need to update documentation, but would appreciate any thoughts you have about the code changes in the meantime. Also - this PR will have conflicts with #8376. I'll resolve them when that one goes in. |
Started regression tests here: I expect many changes for NIRSpec MOS tests: the order of slit processing has changed, which rearranges all the extensions in the products. It was previously processing slitlet IDs from an unordered set; it will now process them in the order they appear in the MSA file. |
Okay, I've added documentation everywhere I could think of, and I have merged in the wavecorr changes, so I'm going to take this out of draft now. New regression test run started here: Testing locally, I see the changes I expected for test_nirspec_mos_spec2, due to rearranging the slit order. After my last update, I now see no changes for test_nirspec_fs_spec2, except some pixel_replace differences that also appear when testing with master. I see no changes for test_nirspec_fs_spec3 or test_nirspec_mos_spec3. |
Resolves JP-3102
Closes #7769
Process fixed slits defined in MSA metafiles, alongside standard MOS slits.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR