-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression test for JP-3604 #8477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8477 +/- ##
=======================================
Coverage 57.93% 57.93%
=======================================
Files 387 387
Lines 38839 38852 +13
=======================================
+ Hits 22502 22510 +8
- Misses 16337 16342 +5 ☔ View full report in Codecov by Sentry. |
Regression test failures are unrelated. |
I was thinking of having a lightweight unit test instead of a regression test but got delayed by the |
Seems uncontroversial, merging. |
Related to JP-3604
This PR adds a regression test to verify the solution for the failure in JP-3604
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionupdated relevant documentationHow to run regression tests on a PR
regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1433/