Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression test for JP-3604 #8477

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

nden
Copy link
Collaborator

@nden nden commented May 10, 2024

Related to JP-3604

This PR adds a regression test to verify the solution for the failure in JP-3604

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

@nden nden added this to the Build 11.0 milestone May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.93%. Comparing base (781e0e0) to head (1892452).
Report is 2 commits behind head on master.

❗ Current head 1892452 differs from pull request most recent head f77aa76. Consider uploading reports for the commit f77aa76 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8477   +/-   ##
=======================================
  Coverage   57.93%   57.93%           
=======================================
  Files         387      387           
  Lines       38839    38852   +13     
=======================================
+ Hits        22502    22510    +8     
- Misses      16337    16342    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jwst/regtest/test_niriss_image.py Outdated Show resolved Hide resolved
jwst/regtest/test_niriss_image.py Show resolved Hide resolved
@hbushouse
Copy link
Collaborator

Regression test failures are unrelated.

@mcara
Copy link
Member

mcara commented May 13, 2024

I was thinking of having a lightweight unit test instead of a regression test but got delayed by the spherical_geometry issues but since this is already done - it's perfectly fine.

@nden
Copy link
Collaborator Author

nden commented May 15, 2024

Seems uncontroversial, merging.

@nden nden merged commit 3df35ef into spacetelescope:master May 15, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants