-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failure in niriss tweakreg test #8489
Fix failure in niriss tweakreg test #8489
Conversation
84eac5a
to
51b0abd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8489 +/- ##
==========================================
+ Coverage 57.93% 58.01% +0.07%
==========================================
Files 387 387
Lines 38839 38811 -28
==========================================
+ Hits 22502 22515 +13
+ Misses 16337 16296 -41 ☔ View full report in Codecov by Sentry. |
Another regtest run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. All regtests are passing, including this new one to test the failure condition (step skipped when no sources are found).
This PR addresses an issue where a regression test may fail even though the code is working as expected (I think).
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR