Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in niriss tweakreg test #8489

Merged
merged 4 commits into from
May 18, 2024

Conversation

mcara
Copy link
Member

@mcara mcara commented May 16, 2024

This PR addresses an issue where a regression test may fail even though the code is working as expected (I think).

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@mcara mcara force-pushed the fix-niriss-tweakreg-test branch from 84eac5a to 51b0abd Compare May 16, 2024 20:23
@mcara
Copy link
Member Author

mcara commented May 16, 2024

@mcara mcara added this to the Build 10.0.1 milestone May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.01%. Comparing base (781e0e0) to head (a0c3f14).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8489      +/-   ##
==========================================
+ Coverage   57.93%   58.01%   +0.07%     
==========================================
  Files         387      387              
  Lines       38839    38811      -28     
==========================================
+ Hits        22502    22515      +13     
+ Misses      16337    16296      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator

@mcara
Copy link
Member Author

mcara commented May 18, 2024

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. All regtests are passing, including this new one to test the failure condition (step skipped when no sources are found).

@hbushouse hbushouse merged commit 6fe0ef3 into spacetelescope:master May 18, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants