Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3637: Add error propagation during IFU annular background subtraction #8515

Merged
merged 4 commits into from
May 30, 2024

Conversation

drlaw1558
Copy link
Collaborator

@drlaw1558 drlaw1558 commented May 29, 2024

Resolves JP-3637 by propagating uncertainties in the annular background to the background-subtracted spectrum during IFU spectral extraction.

Closes #8514

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@drlaw1558 drlaw1558 requested a review from a team as a code owner May 29, 2024 14:32
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.88%. Comparing base (4179c09) to head (15d67a7).
Report is 4 commits behind head on master.

Files Patch % Lines
jwst/extract_1d/ifu.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8515      +/-   ##
==========================================
- Coverage   57.97%   57.88%   -0.10%     
==========================================
  Files         387      387              
  Lines       38830    38865      +35     
==========================================
- Hits        22513    22498      -15     
- Misses      16317    16367      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 11.0 milestone May 30, 2024
@hbushouse
Copy link
Collaborator

@hbushouse
Copy link
Collaborator

Regression test run shows failures/differences for 4 MIRI MRS x1d products, where the FLUX_ERROR column entries are 5-20% higher than previously. Assuming this is the expected level of differences. There's no effect on tests for any other modes. So this looks good.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look to be appropriate and regtest results look good. I approve this PR.

@hbushouse hbushouse merged commit 51d5ba5 into spacetelescope:master May 30, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IFU 1d spectral extraction doesn't account for noise in annular background subtraction
2 participants