Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ruff style check #8615

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix ruff style check #8615

merged 2 commits into from
Jun 27, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 27, 2024

Ruff 0.5 removed ruff <path> in favor of ruff check <path>.
https://astral.sh/blog/ruff-v0.5.0#removed-deprecated-features

This change broke our style check
#8600 (comment)

This PR fixes the check and adds a noqa to jwst/lib/engdb_direct.py for a new F811 failure.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@emolter
Copy link
Collaborator

emolter commented Jun 27, 2024

style check is failing ;)

@braingram
Copy link
Collaborator Author

I might ask who let the dogs out on this one...

@braingram braingram enabled auto-merge June 27, 2024 19:36
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (23fb5cd) to head (064208c).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8615      +/-   ##
==========================================
+ Coverage   59.54%   59.56%   +0.02%     
==========================================
  Files         391      391              
  Lines       39292    39285       -7     
==========================================
+ Hits        23396    23402       +6     
+ Misses      15896    15883      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit ce9a135 into spacetelescope:master Jun 27, 2024
28 checks passed
@braingram braingram deleted the ruff_check branch June 27, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants