Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query MAST with new instrument/mode values due to change in MAST definitions #31

Merged

Conversation

bhilbert4
Copy link
Collaborator

Replacement for #29
Resolves #28

MAST has recently been updated such that the values the in "instrument" column are no longer e.g. "MIRI" but instead include information on the mode as well (e.g. "MIRI/IMAGE"). Because of this, when querying for only e.g. "MIRI", the results included only files which have not yet been reprocessed in MAST to use the new format. This PR works around this change by making a query using the Observations class in the MAST API. This initial query (which can use a wildcard for its search e.g. "MIRI*") returns a list of the instrument/mode values in the data of interest. This instrument/mode list is then placed into the original query to the Jwst.Filtered database, in order to get back filenames.

This PR replaces #29 just because git after the merge of #30, I tried to rebase the branch for #29 but git continued acting as if all of the changes from #30 were new. This made it hard to see the real changes in #29. So I started again with a new branch off of main (which include the updates for #30). So now the only changes listed in here are those directly related to the MAST updates (along with a bunch of spaces that are removed, thanks to sublime text).

@bhilbert4
Copy link
Collaborator Author

I tested this fix using the command below, and am now seeing data acquired after Feb 28 (which is when the MAST update started automatically working on new data). In the results I see files with both MIRI and MIRI/IMAGE instrument values.

python jwst_download.py -v --propID 2311 --config jwst_query.cfg --lookbacktime 13 --instrument miri --filetypes uncal

@bhilbert4 bhilbert4 merged commit db68f7c into spacetelescope:main Mar 10, 2023
@bhilbert4 bhilbert4 deleted the mast-query-inst-column-name-update branch March 10, 2023 19:37
@bhilbert4 bhilbert4 mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble downloading data acquired after Feb 28.
1 participant