Restore ability to download guidestar data #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, guide star filtering was being done twice: once in product_search() and a second time in product_filter(). Since we are talking about filtering guide star entries, I kept the code in product_filter(), and removed it from product_search(). |
|
Testing with program 1068, using guidestars and guidestar_data_only from both the command line and from within the config file all work as expected. |
|
@arminrest any comments on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks to the behavior of the guide star keyword and filtering behavior in order to restore the ability to download the guidestar data. Previously the product_filter function was always being called with the option set to remove the guide star entries.
This PR also adds the guidestar_data_only argument. If this is set to True, then the science products will be filtered out and only the guidestar data will be downloaded. This is inspired by some upcoming work that will design a calibration pipeline for guidestar data.