Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astroquery.mast.tesscut tutorial #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mgough-970
Copy link
Collaborator

No description provided.

@ttdu
Copy link
Collaborator

ttdu commented Jun 21, 2023

@jaymedina Two major bits of feedback

  1. This PR is based on the old folder structure notebooks/MAST/[mission], rather than the new notebooks/[mission]. I am not git savvy enough to do a proper fast-forwarding with a major directory restructuring; could you re-submit on a newer copy of main? I'm also happy to do this, but I wanted to make sure you were credited appropriately for the Notebook in the git history.
  2. Has hapcut been publicly released on 0.4.6? I'm getting an import error even though I meet the criteria listed in the requirements.txt file

@jaymedina
Copy link
Contributor

Hi Thomas! A new version of astroquery has not been released since the new implementation of astroquery.mast.Hapcut, so that's definitely a blocker, and this PR shouldn't move forward until that happens (telling people to get the latest developer version of astroquery just for this one tool seems like it would be more hassle than it's worth). I'll stay in communications with the astroquery maintainers for when their next release will be, and I'll update this PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants