Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logspace() calls for numpy 1.18+ #347

Merged
merged 1 commit into from Jan 23, 2020

Conversation

ehpor
Copy link
Contributor

@ehpor ehpor commented Jan 23, 2020

As of numpy 1.12 passing a non-integer number of samples for logspace() was deprecated. As of numpy 1.18, this is now mandatory, yielding an error when you do pass a float anyway.

logspace() now requires an integer number of samples.
@coveralls
Copy link

coveralls commented Jan 23, 2020

Pull Request Test Coverage Report for Build 210

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.536%

Totals Coverage Status
Change from base Build 207: 0.0%
Covered Lines: 3975
Relevant Lines: 5480

💛 - Coveralls

@mperrin
Copy link
Collaborator

mperrin commented Jan 23, 2020

Thanks @ehpor!

Travis test failed on Py3.5 because of an unrelated issue; that will be fixed in #348. OK to merge now despite the failing test.

@mperrin mperrin merged commit 9218064 into spacetelescope:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants