Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with rotation of HexSegDMs #371

Merged
merged 1 commit into from Jun 25, 2020

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Jun 25, 2020

Fix coordinated issue with influence functions for rotation of hexagonally segmented DMs. Adds unit test for the correct behavior too.

@mperrin mperrin requested a review from kjbrooks June 25, 2020 20:58
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #371 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #371   +/-   ##
========================================
  Coverage    71.02%   71.02%           
========================================
  Files           17       17           
  Lines         5732     5732           
========================================
  Hits          4071     4071           
  Misses        1661     1661           
Impacted Files Coverage Δ
poppy/dms.py 43.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a4278...68812d7. Read the comment docs.

Copy link
Collaborator

@kjbrooks kjbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mperrin mperrin merged commit 32e5bf1 into spacetelescope:develop Jun 25, 2020
@mperrin mperrin deleted the fix-hexdm-rotations branch January 5, 2021 21:53
@mperrin mperrin added this to the 0.9.2 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants