Change for loop calculating OPD from Zernikes to an Einstein sum. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code that uses opd_from_zernikes heavily this can produce a significant speedup since einsum is a highly optimized, multithreaded function.
Codecov Report
@@ Coverage Diff @@
## develop #400 +/- ##
===========================================
- Coverage 74.21% 74.20% -0.01%
===========================================
Files 17 17
Lines 5829 5827 -2
===========================================
- Hits 4326 4324 -2
Misses 1503 1503
Continue to review full report at Codecov.
|
|
I can't seem to explicitly add a reviewer to this pull request. Will follow-up with Marshall or Shannon as to whether this is a problem. |
mperrin
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
👍 A nice optimization, thanks @grbrady
Some benchmarks from calls to opd_from_zernikes show 2x or better speedup:
| # zernikes | Npix | using for loop | using einsum |
|---|---|---|---|
| 36 | 512 | 21.7 ms | 10.8 ms |
| 36 | 1024 | 116 ms | 49.1 ms |
| 78 | 1024 | 235 ms | 87.4 ms |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change a for loop in the opd_from_zernikes function in Zernikes.py to an Einstein sum. This produced a significant speedup in code that I wrote (JWST field dependence model in WebbPSF) that uses the function heavily. This employs the Numpy einsum function, which is a highly optimized, multithreaded implementation. Possibly downside is that the Einstein sum notation is a little less readable to most people.