Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units error in MultiHexagonAperture, see #485 #527

Merged
merged 1 commit into from Sep 12, 2022

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Sep 12, 2022

Fixes #485

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 74.73% // Head: 74.84% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (568fc7c) compared to base (7d3e3bf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #527      +/-   ##
===========================================
+ Coverage    74.73%   74.84%   +0.10%     
===========================================
  Files           18       18              
  Lines         6476     6499      +23     
===========================================
+ Hits          4840     4864      +24     
+ Misses        1636     1635       -1     
Impacted Files Coverage Δ
poppy/optics.py 81.91% <100.00%> (+0.02%) ⬆️
poppy/wfe.py 81.27% <0.00%> (+0.03%) ⬆️
poppy/poppy_core.py 80.94% <0.00%> (+0.04%) ⬆️
poppy/sub_sampled_optics.py 67.41% <0.00%> (+0.14%) ⬆️
poppy/dms.py 46.40% <0.00%> (+0.27%) ⬆️
poppy/fresnel.py 84.92% <0.00%> (+0.35%) ⬆️
poppy/instrument.py 67.66% <0.00%> (+0.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mperrin mperrin merged commit 4e25b8e into spacetelescope:develop Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Astropy quantity comparison in CompoundAnalyticOptic
1 participant