New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to mark levels in display_ee #540
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #540 +/- ##
===========================================
- Coverage 74.84% 72.66% -2.18%
===========================================
Files 18 18
Lines 6499 6479 -20
===========================================
- Hits 4864 4708 -156
- Misses 1635 1771 +136
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…-float replacing np.float with np.float_ per Issue 544
…ersion_update Update minimum versions across the board
@douglase I just pushed changes to develop that will fix your failing tests. If you fetch/merge we can move forward with this PR. |
…to douglase-patch-5
I merged the latest develop into this and have pushed it here, which should hopefully get all the tests passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
For the record, most of the changes in this PR as seen in GitHub are other recent PRs which I just merged into this to update it to the current develop. The only actual changes specific to this PR are those in utils.py, which I reviewed and approve.
current behavior when
utils.display_ee
is called is to label 50, 80, and 95% encircled energy. This breaks when a level is not encircled by the PSF. This PR adds the option for the user to specify custom levels with a keywordlevels
. if the keyword is not specified then there is no change to the existing behavior.