Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to mark levels in display_ee #540

Merged
merged 12 commits into from Mar 24, 2023

Conversation

douglase
Copy link
Collaborator

current behavior when utils.display_ee is called is to label 50, 80, and 95% encircled energy. This breaks when a level is not encircled by the PSF. This PR adds the option for the user to specify custom levels with a keyword levels. if the keyword is not specified then there is no change to the existing behavior.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -2.18 ⚠️

Comparison is base (1dccb8d) 74.84% compared to head (acfe870) 72.66%.

❗ Current head acfe870 differs from pull request most recent head 4ee9666. Consider uploading reports for the commit 4ee9666 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #540      +/-   ##
===========================================
- Coverage    74.84%   72.66%   -2.18%     
===========================================
  Files           18       18              
  Lines         6499     6479      -20     
===========================================
- Hits          4864     4708     -156     
- Misses        1635     1771     +136     
Impacted Files Coverage Δ
poppy/utils.py 53.29% <20.00%> (-0.25%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradleySappington
Copy link
Collaborator

@douglase I just pushed changes to develop that will fix your failing tests. If you fetch/merge we can move forward with this PR.

@mperrin
Copy link
Collaborator

mperrin commented Mar 24, 2023

I merged the latest develop into this and have pushed it here, which should hopefully get all the tests passing.

Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
For the record, most of the changes in this PR as seen in GitHub are other recent PRs which I just merged into this to update it to the current develop. The only actual changes specific to this PR are those in utils.py, which I reviewed and approve.

@mperrin mperrin merged commit 7b8d44a into spacetelescope:develop Mar 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants