Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAD-134: Added GuideWindow db table to Basic tagged scalars. #327

Merged
merged 4 commits into from Oct 19, 2023
Merged

RAD-134: Added GuideWindow db table to Basic tagged scalars. #327

merged 4 commits into from Oct 19, 2023

Conversation

PaulHuwe
Copy link
Collaborator

Resolves RAD-134

Closes #316

This PR adds GuideWindow db table to Basic tagged scalars.

Checklist

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@PaulHuwe PaulHuwe marked this pull request as ready for review October 12, 2023 21:59
@PaulHuwe PaulHuwe requested review from WilliamJamieson and a team as code owners October 12, 2023 21:59
@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Oct 12, 2023
Closed
ddavis-stsci
ddavis-stsci approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe linked an issue Oct 19, 2023 that may be closed by this pull request
Archive Destination Needs Updating in Basic #262
Closed
@PaulHuwe PaulHuwe merged commit cb46dd6 into spacetelescope:main Oct 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddavis-stsci ddavis-stsci ddavis-stsci approved these changes

@jbrookens jbrookens jbrookens approved these changes

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Basic Keywords to Include GuideTable Archive Destination Needs Updating in Basic
3 participants
@PaulHuwe @ddavis-stsci @jbrookens