Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-140: Remove the unused variance schema #344

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Dec 8, 2023

Resolves RAD-14

Closes #343

The variance schema is not used by anything, nor is it even supported by roman_datamodels

Checklist

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b41cdd6) 95.32% compared to head (44c27d4) 95.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   95.32%   95.32%           
=======================================
  Files           4        4           
  Lines         171      171           
=======================================
  Hits          163      163           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Dec 8, 2023

Have you confirmed that RDM will not need an update to match this removal?

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson
Copy link
Contributor Author

Have you confirmed that RDM will not need an update to match this removal?

Yes, greping for variance indicates no mentions of it within the code base. Moreover, roman_datamodels is only directly aware of any tagged schemas and variance is not a tagged schema.

@WilliamJamieson WilliamJamieson merged commit 4846829 into spacetelescope:main Dec 11, 2023
13 checks passed
@WilliamJamieson WilliamJamieson deleted the cleanup/remove_variance branch December 11, 2023 20:09
stscieisenhamer pushed a commit to stscieisenhamer/rad that referenced this pull request Jan 19, 2024
stscieisenhamer pushed a commit to stscieisenhamer/rad that referenced this pull request Jan 23, 2024
@nden nden added this to the Build 13 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Variance
4 participants