Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-154: Improve documentation #386

Merged
merged 4 commits into from Feb 28, 2024
Merged

RAD-154: Improve documentation #386

merged 4 commits into from Feb 28, 2024

Conversation

nden
Copy link
Collaborator

@nden nden commented Feb 28, 2024

Resolves RAD-154

Closes #381

This PR adds newly added schemas to the documentation.
It also rearranges the list of schemas placing the science products at the top.

Checklist

@nden nden requested a review from a team as a code owner February 28, 2024 14:51
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (0fb1239) to head (0ff0252).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           4        4           
  Lines         195      195           
=======================================
  Hits          186      186           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden nden added this to the Build 14 milestone Feb 28, 2024
@nden nden added the documentation Improvements or additions to documentation label Feb 28, 2024
docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
wfi_mode-1.0.0
wfi_optical_element-1.0.0
wfi_science_raw-1.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add TVAC & FPS, now that they are merged?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are only internal I think we shouldn't.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggested wording.

@nden nden merged commit ae17bd0 into spacetelescope:main Feb 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAD documentation improvements
2 participants