Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-165: Separate TVAC and FPS Schemas from Main #414

Merged
merged 9 commits into from
May 9, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented May 1, 2024

Resolves RAD-165

Closes #407

This PR creates a suite of separate TVAC and FPS schemas to freeze them and keep them separate from main development. NOTE: archive catalog targets need updating, which I will split out into another ticket.

Checklist

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (c1811ab) to head (a3c657d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%     
==========================================
  Files           4        4              
  Lines         195      198       +3     
==========================================
+ Hits          186      189       +3     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review May 1, 2024 01:40
@PaulHuwe PaulHuwe requested review from kdupriestsci, jbrookens and a team as code owners May 1, 2024 01:40
Copy link
Collaborator

@jbrookens jbrookens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question I had was the archive catalog destinations being a superset, but I see you're handling those updates as a future ticket. No other concerns from me.

@nden
Copy link
Collaborator

nden commented May 1, 2024

Looks good to me.
For my understanding - since these files are stored in a different archive, is the archive_catalog section even needed?

@jbrookens
Copy link
Collaborator

jbrookens commented May 1, 2024

Looks good to me. For my understanding - since these files are stored in a different archive, is the archive_catalog section even needed?

Still needed.

@kdupriestsci
Copy link
Collaborator

It looks like there's a lot of duplicated data between the fps and tvac folders. Can any of those files be shared between the two?

I understand that you don't want to share with science data since the science schemas are in flux, but does that problem exist at the individual test level as well?

@kdupriestsci
Copy link
Collaborator

You've left references to ScienceRefData and GuideWindow tables in the tvac and fps files. We don't have ScienceRefData for RITA (it's stored in WFICommon. We don't have GuideWindow for RITA (my understanding is we don't have GuideWindows for test data).

@kdupriestsci
Copy link
Collaborator

Will the RITA schemas always be isolated from the Roman schemas? If yes, maybe Tim @relaxing could make use of the archive_meta tag (currently set to None) to distinguish Roman from RITA?

@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented May 3, 2024

It looks like there's a lot of duplicated data between the fps and tvac folders. Can any of those files be shared between the two?

I understand that you don't want to share with science data since the science schemas are in flux, but does that problem exist at the individual test level as well?

It was decided to freeze TVAC and FPS individually, which means we need to keep the duplicates.

@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented May 3, 2024

Will the RITA schemas always be isolated from the Roman schemas? If yes, maybe Tim @relaxing could make use of the archive_meta tag (currently set to None) to distinguish Roman from RITA?

This sounds good to me.. do you want to discuss it at a RAD meeting, or just have @relaxing implement it as it is an archive only keyword?

@nden nden mentioned this pull request May 6, 2024
4 tasks
@PaulHuwe PaulHuwe merged commit 60afc24 into spacetelescope:main May 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone TVAC and FPS Schemas
4 participants