Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-169: Drop filename_l1a and filename_pnt5 from database for TVAC and FPS schemas #421

Merged

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented May 10, 2024

Resolves RAD-169

Closes #416

This PR removed the db entries for filename_l1a and filename_pnt5 in TVAC and FPS schemas

Checklist

@PaulHuwe PaulHuwe marked this pull request as ready for review May 10, 2024 16:30
@PaulHuwe PaulHuwe requested a review from a team as a code owner May 10, 2024 16:30
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (c1811ab) to head (bba507c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   95.38%   95.45%   +0.06%     
==========================================
  Files           4        4              
  Lines         195      198       +3     
==========================================
+ Hits          186      189       +3     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@fjaviersanchez fjaviersanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@PaulHuwe PaulHuwe merged commit 968e47b into spacetelescope:main May 14, 2024
13 checks passed
@PaulHuwe PaulHuwe deleted the RAD-169_RemoveTVACFPSFilenamesDB branch May 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop filename_l1a and filename_pnt5 from database for TVAC and FPS schemas
3 participants