Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy assertion for mode equality from asdf-astropy #79

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

nden
Copy link
Collaborator

@nden nden commented Apr 26, 2022

This PR copies asdf-astropy.testing.helpers.assert_model_equal to roman_datamodels.testing.assertions.
The testing functions in roman_datamodels are used by CRDS tests. However, CRDS tests do not use pytest and CRDS has no dependency on pytest. Importing from asdf-astropy adds pytest as a dependency of CRDS which is undesirable.

Alternatively this can be fixed in asdf-astropy in a future release because the pytest dependency is coming from an import from astropy.units which can be done within a function. However, in the interest of releasing this for build 6, the function is copied now here.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #79 (160d989) into main (9ef4230) will increase coverage by 0.37%.
The diff coverage is 100.00%.

❗ Current head 160d989 differs from pull request most recent head 543955b. Consider uploading reports for the commit 543955b to get more accurate results

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   66.07%   66.45%   +0.37%     
==========================================
  Files          15       15              
  Lines        1981     2003      +22     
==========================================
+ Hits         1309     1331      +22     
  Misses        672      672              
Impacted Files Coverage Δ
src/roman_datamodels/testing/assertions.py 97.95% <100.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef4230...543955b. Read the comment docs.

Copy link

@alphasentaurii alphasentaurii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants