-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_tweakreg
regression test failing
#1132
Comments
Hello @braingram Good Morning. My son interested in Astronomy so thought of seeing any open source and got this repository. I just reviewed your comment with the error, as per that I think it could be due to the below line in the romancal/regtest/test_tweakreg.py file line # 27 rtdata.get_truth(f"truth/WFI/image/{truth_data}") it has to be like the below may help to solve this issue. rtdata.get_truth(f"WFI/image/{truth_data}") Thanks. |
I think we're passing all the regtests now. e.g. |
Since the failure disappeared following an input file change, is it expected that |
Reviewing your log, I think you're saying that you want this failure mode romancal/romancal/tweakreg/tweakreg_step.py Line 593 in 3b1ac52
That certainly sounds desirable to me but somewhat low priority as we have a good log message and aren't making any output in this case? |
Thanks for the reply and looking into it. I believe it was a failure to fetch gaia data that caused the step to silently fail and not produce a file. The romancal/romancal/tweakreg/tests/test_tweakreg.py Line 1180 in 3b1ac52
which did not fail in the linked run (the test passed due to the step raising an exception). Unfortunately for the jenkins run where I provided I think the portion of the log that corresponds to the failed test is:
With the romancal/romancal/tweakreg/tweakreg_step.py Lines 434 to 448 in 3b1ac52
Since that sets skip = True the results are not saved (due to this check in stpipe).
To summarize, if an exception occurs during gaia data fetching |
Thanks Brett. Yes, I'm confused about whether the step passed or failed; I thought it was this one and it failed?
But yes, I agree that if we don't find a catalog tweakreg isn't doing something and we should fail harder than just skipping the step. |
That's the one! The error romancal/romancal/regtest/test_tweakreg.py Lines 35 to 42 in 3b1ac52
For the failing runs the test failed on the rdm.open .
|
The
test_tweakreg
test is failing on main withDuring a regtest run with
-k test_tweakreg -s
(to show the log output).https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/638/pipeline/245
The
test_tweakreg
test failed to produce the output file and there are several warning messages like the following in the log:The text was updated successfully, but these errors were encountered: