Fix DMS requirement number #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1127 +/- ##
==========================================
- Coverage 76.73% 76.72% -0.02%
==========================================
Files 105 105
Lines 7054 7054
==========================================
- Hits 5413 5412 -1
- Misses 1641 1642 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddavis-stsci
approved these changes
Mar 5, 2024
schlafly
approved these changes
Mar 5, 2024
romancal/regtest/test_wfi_dq_init.py
Outdated
| @@ -68,7 +68,7 @@ def test_dq_init_image_step(rtdata, ignore_asdf_paths): | |||
| assert diff.identical, diff.report() | |||
|
|
|||
|
|
|||
| @metrics_logger("DMS26") | |||
| @metrics_logger("DMS25") | |||
| @pytest.mark.bigdata | |||
| def test_dq_init_grism_step(rtdata, ignore_asdf_paths): | |||
| """DMS26 Test: Testing retrieval of best ref file for grism data, | |||
There was a problem hiding this comment.
Suggested change
| """DMS26 Test: Testing retrieval of best ref file for grism data, | |
| """DMS25 Test: Testing retrieval of best ref file for grism data, |
|
Oo, I never checked. Fixed all of them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-nnnn
Closes #
This PR addresses ...
Checklist
CHANGES.rstunder the corresponding subsection