-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure logs get included in L3 products. #1207
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
+ Coverage 76.78% 79.03% +2.25%
==========================================
Files 113 116 +3
Lines 7933 7985 +52
==========================================
+ Hits 6091 6311 +220
+ Misses 1842 1674 -168
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regtests are "passing"; two new failures because of the added individual_image_cal_logs bit in the asdf file. If we like this approach, we should exclude those from compare_asdf. |
After adding individual_image_cal_logs to the list of extensions to ignore, regtests actually pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks a bit messy but all the info appears to be copied.
This PR leads HLP products to have their "cal_logs" attribute filled out.
Previously these were not being populated because stpipe.core was explicitly checking that the output datamodel was an ImageModel. This PR changes that to check if it's either an ImageModel or a MosaicModel. It also clears the CalLogs when making a new output model to avoid some initial filler values.
Finally, a big portion of the HLP is processing the input L2s; flux calibration, sky matching, outlier detection. Those logs go into the L2 products which we do not save. This adds a new individual_image_cal_logs extension parallel to cal_logs that houses the individual L2 log messages. We probably want that?
Checklist
CHANGES.rst
under the corresponding subsection