Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect boolean comparison within isfile() #1210

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented May 1, 2024

This PR addresses problems brought by sonarqube: https://plsonarqube.stsci.edu/project/issues?resolved=false&inNewCodePeriod=true&types=BUG&id=romancal&open=AY8c5NNYlU1kwdd-S5_H

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (b61e70b) to head (69485b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1210   +/-   ##
=======================================
  Coverage   79.05%   79.05%           
=======================================
  Files         116      116           
  Lines        7994     7994           
=======================================
  Hits         6320     6320           
  Misses       1674     1674           
Flag Coverage Δ *Carryforward flag
nightly 62.78% <ø> (ø) Carriedforward from d00e8d9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zacharyburnett zacharyburnett enabled auto-merge (squash) May 3, 2024 13:08
@zacharyburnett zacharyburnett merged commit f994833 into spacetelescope:main May 3, 2024
30 checks passed
@zacharyburnett zacharyburnett deleted the fix/regtest_filecheck branch May 3, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants