-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rcal 803 Initial resampling to skycell in the hlp #1214
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 79.05% 79.16% +0.10%
==========================================
Files 116 116
Lines 7994 8045 +51
==========================================
+ Hits 6320 6369 +49
- Misses 1674 1676 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Some notes:
- I hadn't thought about this before, but it's a little ~interesting that we are doing outlier detection & sky matching using the full SCAs, but the projection using only the skycell area. For the outlier detection that's wasteful, but probably not horribly so. For the sky matching it produces different results, but probably different results in a mildly beneficial way. I think we should just document that behavior for now.
- I agree with the code comments that we'll probably want to refactor this to get resample to take a WCS directly rather than via a file.
- I think I had the impression that you wanted to add some associated regtest demonstrating the L3 pipeline on skycells?
Resolves RCAL-803
Closes #1162
This PR adds the ability to use an association to resample the members to the output product based on a skycell definition.
Checklist
CHANGES.rst
under the corresponding subsectionThe regression tests at https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/732/
are passing.