Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: OSX ARM64 throws RuntimeWarning now #263

Closed
wants to merge 1 commit into from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 25, 2024

I don't know why though.

xref #262

@pllim pllim added the Build wheels Build wheels on PR label Apr 25, 2024
@pllim
Copy link
Contributor Author

pllim commented Apr 25, 2024

Huh, CI was disabled due to inactivity. I have to close/reopen to trigger it. The OSX ARM64 wheel job did pass though, but this is more like a bandaid. I think we need to understand why it is throwing RuntimeWarning and not ValueError as stated here:

if (s.x[0] != s.x[0] ||
s.x[0] < -1.0 ||
s.x[0] > 1.0) {
PyErr_SetString(PyExc_ValueError, "Out of domain for acos");
return 1;
}

Thanks to @jhunkeler for digging out the code.

@pllim pllim closed this Apr 25, 2024
@pllim pllim reopened this Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (5de7fc7) to head (d311a3d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files           5        5           
  Lines        1010     1010           
=======================================
  Hits          821      821           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Apr 25, 2024

devdeps failure is unrelated (#261)

@pllim pllim marked this pull request as ready for review April 25, 2024 21:55
@pllim pllim requested a review from a team as a code owner April 25, 2024 21:55
Copy link
Member

@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiding these errors is not a good solution.

@mcara
Copy link
Member

mcara commented Apr 28, 2024

The problems appear to be due to import failure of math_util even though math_util...so is built. very strange. If this import fails, the code fallback to the Python code. Probably that code is buggy too and hence the errors. So, two things need to be fixed: Python code and import of the compiled C module build with numpy 2.0.

@pllim
Copy link
Contributor Author

pllim commented Apr 29, 2024

OK then I'll leave it to the experts. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build wheels Build wheels on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants