-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: OSX ARM64 throws RuntimeWarning now #263
Conversation
for some reason
Huh, CI was disabled due to inactivity. I have to close/reopen to trigger it. The OSX ARM64 wheel job did pass though, but this is more like a bandaid. I think we need to understand why it is throwing RuntimeWarning and not ValueError as stated here: spherical_geometry/src/math_util.c Lines 250 to 255 in 5de7fc7
Thanks to @jhunkeler for digging out the code. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 81.28% 81.28%
=======================================
Files 5 5
Lines 1010 1010
=======================================
Hits 821 821
Misses 189 189 ☔ View full report in Codecov by Sentry. |
devdeps failure is unrelated (#261) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hiding these errors is not a good solution.
The problems appear to be due to import failure of |
OK then I'll leave it to the experts. Thanks! |
I don't know why though.
xref #262