Skip to content
This repository has been archived by the owner on Nov 5, 2020. It is now read-only.

imstat vs astropy/python stats #83

Closed
SaOgaz opened this issue Mar 22, 2018 · 1 comment
Closed

imstat vs astropy/python stats #83

SaOgaz opened this issue Mar 22, 2018 · 1 comment
Milestone

Comments

@SaOgaz
Copy link
Collaborator

SaOgaz commented Mar 22, 2018

Look into differences in run time and result values. See #54 for some background.

@SaOgaz SaOgaz added this to the V1.1 milestone Mar 29, 2018
@SaOgaz
Copy link
Collaborator Author

SaOgaz commented May 22, 2018

Run time differences is being fixed in astropy/astropy#7478.

We tracked the inconsistent result values into the difference in the clipping. Numpy uses a simple median as the center point for clipping, while IRAF does the following:

the midpoint is estimated by integrating the histogram and computing by interpolation the data value at which exactly half the pixels are below that data value and half are above it

You can define the midpoint in numpy through the cenfunc parameter for any users that really need to exactly replicate the IRAF algorithm. I will close this issue when I've updated the notebook with this note.

@SaOgaz SaOgaz closed this as completed in 3b4cae4 May 22, 2018
SaOgaz added a commit that referenced this issue May 22, 2018
updated imstat note about value differences, closes #83
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant