remove use of pkg_resources #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added
the
no-changelog-entry-needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 64.67% 64.66% -0.01%
==========================================
Files 102 102
Lines 5664 5660 -4
==========================================
- Hits 3663 3660 -3
+ Misses 2001 2000 -1 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
remove_pkg_resources
branch
from
90e73bb
to
d358d76
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
braingram
force-pushed
the
remove_pkg_resources
branch
2 times, most recently
from
490a80b
to
3728d0d
Compare
braingram
force-pushed
the
remove_pkg_resources
branch
from
3728d0d
to
347ccb4
Compare
braingram
force-pushed
the
remove_pkg_resources
branch
from
347ccb4
to
adc1e0a
Compare
WilliamJamieson
approved these changes
Oct 31, 2023
braingram
force-pushed
the
remove_pkg_resources
branch
from
adc1e0a
to
db314e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated. It's use in stdatamodels is limited to parsing the asdf version to check if it's at least 2.6. The pyproject.toml dependencies set a lower pin on asdf version 2.15.0 making the check in the code unnecessary:
stdatamodels/pyproject.toml
Line 15 in 27c3974
This PR removes the use of pkg_resources.
This is causing issues for 3.12 testing as seen in: #216
Regression tests passed with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/967/
Checklist
CHANGES.rst(either inBug FixesorChanges to API)