Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide asn_n_members=1 when opening dataset for Step to call get_crds_parameters #142

Merged
merged 1 commit into from Feb 27, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 22, 2024

This PR improves the consistency of the parameters used for _datamodels_open by providing asn_n_members=1 for Step (to match what is done in Pipeline).

Fixes spacetelescope/jwst#8262

Romancal regtests all pass: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/608/
JWST regtests show 4 unrelated errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1226/
(the same errors are seen in a run without this PR using the current JWST default branch: ttps://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1227/

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 59.33%. Comparing base (aea1617) to head (8c8bdd2).
Report is 1 commits behind head on main.

❗ Current head 8c8bdd2 differs from pull request most recent head 66012fb. Consider uploading reports for the commit 66012fb to get more accurate results

Files Patch % Lines
src/stpipe/step.py 0.00% 3 Missing ⚠️
src/stpipe/pipeline.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   59.15%   59.33%   +0.18%     
==========================================
  Files          24       24              
  Lines        1611     1606       -5     
==========================================
  Hits          953      953              
+ Misses        658      653       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram changed the title use get_crds_parameters on ModelContainer Provide asn_n_members=1 when opening dataset for Step to call get_crds_parameters Feb 22, 2024
@braingram braingram marked this pull request as ready for review February 23, 2024 14:29
@braingram braingram requested a review from a team as a code owner February 23, 2024 14:29
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
There's a bug in roman_datamodels - it deletes asn_n_members.
In addition _datamodels_open does not work with ModelContainer and ModelContainer does not accept asn_n_memers. A ticket describing the issues is https://jira.stsci.edu/browse/RCAL-777

@braingram braingram merged commit b622618 into spacetelescope:main Feb 27, 2024
14 checks passed
@braingram braingram deleted the get_crds_parameters branch February 27, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling strun outlier_detection with an association reads all files in association to get crds parameters
2 participants