New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor toxenvs, use OpenAstronomy workflows, and move MacOS jobs to schedule #75
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 54.17% 54.17%
=======================================
Files 25 25
Lines 3057 3057
=======================================
Hits 1656 1656
Misses 1401 1401 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General curmudgeon/grey-beard start about flake8 to ruff: Why? Speed-up is a good thing, however version "0.0.187", though usually I do not take much stock in versions, still seems a bit early. Big question is IDE support: Is there any? Also, losing the flake8 configuration will re-introduce unneeded noise. Also, how will this play with depending packages?
Regardless, will need some developer documentation at least stating what is being used.
Mainly, I am looking toward EDIT: moved to #77 |
81189e5
to
f188dc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Related things that could probably be done, in other PRs, include updating the README to document how to install, setup development, test, etc. About time this becomes a proper package.
Also, for the group itself, a discussion on the changes/new stuff, such as tox and linting changes, would be in order. Possibly at an all-hands.
@zacharyburnett it appears there is an issue with CRDS for jwst and romancal, can you take a look at these? I would like to merge this before merging #79. |
@zacharyburnett it looks like CRDS is working for JWST now but not for Roman. Is this because there is not a public CRDS for Roman yet? |
d2f973d
to
7ceb255
Compare
This PR abstracts CI workflows to the OpenAstronomy workflows; this should reduce maintenance for updating and maintaining actions. Additionally, these changes move the majority of MacOS jobs to the weekly scheduled workflow. This should alleviate the issue where the limited MacOS runners for the organization are not available for CI jobs.
tox.ini
withtoxenv
s from Romancalubuntu
andmacos
usemoved to replaceruff
instead offlake8
to check lint rulesflake8
withruff
#77after merging, the Required Statuses should also be updated