Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import tomli as tomllib for docs builds before Python 3.11 #86

Merged
merged 1 commit into from Apr 7, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 9, 2023

tomli is implemented read-only as tomllib in Python 3.11; this change ensures that the documentation build doesn't fail in Python 3.11 and above

@zacharyburnett zacharyburnett self-assigned this Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c52fa4) 54.17% compared to head (b85f801) 54.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   54.17%   54.17%           
=======================================
  Files          25       25           
  Lines        3057     3057           
=======================================
  Hits         1656     1656           
  Misses       1401     1401           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett changed the title make tomli hard dependency for docs import tomli as tomllib for docs builds before Python 3.11 Mar 9, 2023
@zacharyburnett zacharyburnett added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Mar 13, 2023
@WilliamJamieson WilliamJamieson merged commit 4eeb7aa into spacetelescope:master Apr 7, 2023
18 checks passed
@zacharyburnett zacharyburnett deleted the tomli_docs branch April 7, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants