Remove stdatamodels dependency
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
force-pushed
the
refactor/remove_stdatamodels
branch
from
57adcb4
to
a76ec43
Compare
|
The JWST failures are expected, spacetelescope/jwst#7542 needs to be merged in order for that to pass. |
This was referenced Apr 11, 2023
WilliamJamieson
force-pushed
the
refactor/remove_stdatamodels
branch
from
a76ec43
to
64fd359
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 54.03% 54.16% +0.12%
==========================================
Files 25 25
Lines 3046 3024 -22
==========================================
- Hits 1646 1638 -8
+ Misses 1400 1386 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
hbushouse
approved these changes
Apr 12, 2023
nden
approved these changes
Apr 13, 2023
WilliamJamieson
force-pushed
the
refactor/remove_stdatamodels
branch
from
64fd359
to
bc755f6
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
romancalhas a dependency ofstdatamodels; however, there should not be a dependency of the Roman pipeline on JWST pipeline specific packages.The dependency is due to the
stdatamodels.s3_utilsmodule, which is a thing wrapper of the now unsupportedstsci-aws-utilspackage. The introduction ofs3_utilswas largely due to an experiment to see if thejwstpipeline could load reference files from S3. While this experiment was apparently successful, it was intended to be a one-off demonstration and has been largely unused since it completed. @eslavich can provide more details. Moreover, the implantation of S3 support requires client code injwstandromancalto know the source of input data (S3 or local filesystem) and handle the opening of internal files in a distinct fashion. Ideally the steps consuming reference files should not have to be aware of the origin of their files. Instead, CRDS, which provides these files to the steps, should handle this type of detail.