Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use canonical filename of RTD configuration and enable nitpicky #149

Merged
merged 5 commits into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ documentation:
- changed-files:
- any-glob-to-any-file:
- .github/**/*.md
- .readthedocs.yml
- .readthedocs.yaml
- doc/**/*
- '*.md'
- all-globs-to-any-file:
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml → .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# .readthedocs.yml
# .readthedocs.yaml
# Read the Docs configuration file
# See https://docs.readthedocs.io/en/stable/config-file/v2.html for details

Expand Down
6 changes: 6 additions & 0 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,9 @@
(None, 'http://data.astropy.org/intersphinx/matplotlib.inv')),
'astropy': ('https://docs.astropy.org/en/stable/', None)
}

# Enable nitpicky mode - which ensures that all references in the docs resolve.
nitpicky = True
nitpick_ignore = [
('py:class', 'stsci.tools.stpyfits._ConstantValueImageBaseHDU'),
]
14 changes: 10 additions & 4 deletions lib/stsci/tools/bitmask.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def bitfield_to_boolean_mask(bitfield, ignore_flags=0, flip_bits=None,
as "good" values. However, see ``ignore_flags`` parameter on how to
selectively ignore some bits in the ``bitfield`` array data.

ignore_flags : int, str, list, None (Default = 0)
ignore_flags : int, str, list, None
An integer bitmask, a Python list of bit flags, a comma- or
'+'-separated string list of integer bit flags that indicate what
bits in the input ``bitfield`` should be *ignored* (i.e., zeroed), or
Expand Down Expand Up @@ -315,13 +315,15 @@ def bitfield_to_boolean_mask(bitfield, ignore_flags=0, flip_bits=None,
an ``ignore_flags`` string value of ``'~0'`` would be equivalent
to setting ``ignore_flags=None``.

Defaults to ``0``

.. warning::

Because prepending '~' to a string ``ignore_flags`` is equivalent
to setting ``flip_bits`` to `True`, ``flip_bits`` cannot be used
with string ``ignore_flags`` and it must be set to `None`.

flip_bits : bool, None (Default = None)
flip_bits : bool, None
Specifies whether or not to invert the bits of the bitmask either
supplied directly through ``ignore_flags`` parameter or built from the
bit flags passed through ``ignore_flags`` (only when bit flags are
Expand All @@ -337,14 +339,16 @@ def bitfield_to_boolean_mask(bitfield, ignore_flags=0, flip_bits=None,
specified by prepending '~' to string bit flag lists
(see documentation for ``ignore_flags`` for more details).

Defaults to `None`

.. warning::
This parameter can be set to either `True` or `False` **ONLY** when
``ignore_flags`` is either an integer bitmask or a Python
list of integer bit flags. When ``ignore_flags`` is either
`None` or a string list of flags, ``flip_bits`` **MUST** be set
to `None`.

good_mask_value : int, bool (Default = True)
good_mask_value : int, bool
This parameter is used to derive the values that will be assigned to
the elements in the output boolean mask array that correspond to the
"good" bit fields (that are 0 after zeroing bits specified by
Expand All @@ -359,7 +363,9 @@ def bitfield_to_boolean_mask(bitfield, ignore_flags=0, flip_bits=None,
or 0 (if ``dtype`` is of numerical type) and values of corresponding
to "bad" flags will be `True` (or 1).

dtype : data-type
Defaults to `True`

dtype : type, str
The desired data-type for the output binary mask array.

Returns
Expand Down
Loading