Updated Roman throughput to Phase C #149
Conversation
| @@ -285,34 +285,32 @@ The Stromgren *uvby* throughputs are taken from | |||
| >>> bp = stsyn.band('stromgren,y') # doctest: +SKIP | |||
|
|
|||
|
|
|||
| .. _stsynphot-nonhst-wfirst: | |||
| .. _stsynphot-nonhst-roman: | |||
There was a problem hiding this comment.
Hmm... this will break any intersphinx linking in other repos. Do we really need to change this? It is not really visible to the user.
There was a problem hiding this comment.
I think we should change it now rather than later. The mission has been pretty set on removing all the old references to WFIRST in favor of Roman, and I'd prefer to get things changed over earlier while it impacts few if any people rather than later when it could impact more.
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
|
|
||
| >>> import stsynphot as stsyn | ||
| >>> bp = stsyn.band('wfirst,wfi,f062') # doctest: +SKIP |
There was a problem hiding this comment.
Just curious... Existing usage of wfirst will just provide and error now? Or do you secretly alias it to roman for backward compatibility?
There was a problem hiding this comment.
It should provide an error that the component is not found in the TMG/TMC. All of them have been renamed to Roman.
|
Need to update this too: stsynphot_refactor/docs/conf.py Line 141 in 2289bc2 |
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 13 13
Lines 1633 1633
=======================================
Hits 1386 1386
Misses 247 247 Continue to review full report at Codecov.
|
Description
This pull request updates the documentation in Appendix B for non-HST filters for the Roman Space Telescope. The TMG and TMC files in CRDS have been updated to rename the components to Roman, as well as renaming the F146 filter to W146, and adding the new F213 filter component. The documentation has been updated in this pull request to account for these changes.