Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 support, misc clean-ups #185

Merged
merged 6 commits into from Mar 31, 2019
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 31, 2019

Fix #131 , plus other clean-ups.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #185 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #185      +/-   ##
=========================================
- Coverage   96.93%   96.9%   -0.04%     
=========================================
  Files          13      13              
  Lines        1732    1714      -18     
=========================================
- Hits         1679    1661      -18     
  Misses         53      53
Impacted Files Coverage Δ
synphot/observation.py 99.02% <ø> (-0.01%) ⬇️
synphot/thermal.py 100% <ø> (ø) ⬆️
synphot/exceptions.py 100% <ø> (ø) ⬆️
synphot/utils.py 97.89% <ø> (-0.03%) ⬇️
synphot/models.py 89.1% <ø> (-0.09%) ⬇️
synphot/reddening.py 98.93% <ø> (-0.02%) ⬇️
synphot/compat.py 100% <ø> (ø) ⬆️
synphot/__init__.py 100% <ø> (ø) ⬆️
synphot/config.py 100% <ø> (ø) ⬆️
synphot/spectrum.py 99.45% <100%> (-0.01%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d5004...6acb35c. Read the comment docs.

Replace deprecated C-extension usage.
@pllim
Copy link
Contributor Author

pllim commented Mar 31, 2019

Oh yeahhhh

@pllim pllim merged commit 7124dff into spacetelescope:master Mar 31, 2019
@pllim pllim deleted the rm-py2 branch March 31, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant