-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise proper exception when spectrum is not passed #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some irrelevant diff
in your commit. I think you need to rebase with the latest master
upstream. Please let me know if you need help with this. Thanks!
Hii mam, I am new to git, please help me how to do it, or share any reference. Thanks! |
You might want to back up your branch before you do this:
|
@msrdinesh , try poke around |
Hii @pllim, I tried to add the test. There are a couple of errors. Please help me understand where I was wrong. Thanks! |
@msrdinesh , I don't think the errors are related to your patch. Please rebase again in accordance to #228 (comment) and see what happens. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much for your patch and patience!
* Raise proper exception when spectrum is not passed * Added test to check whether exception is raised properly
This pr is to address the issue 206
EDIT: Fixes #206