Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observation to take Spectrum1D as source #246

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Observation to take Spectrum1D as source #246

merged 2 commits into from
Feb 19, 2020

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 17, 2020

Fix #244

@pllim @eteq
Observation takes Spectrum1D as source.
6dd93e1 
Co-authored-by: Erik Tollerud <erik.tollerud@gmail.com>
@pllim pllim added this to the 0.3 milestone Feb 17, 2020
@pllim pllim requested a review from eteq February 17, 2020 21:18
@pllim pllim added this to In progress in Dev Roadmap Feb 17, 2020
@pllim pllim requested a review from nmearl February 17, 2020 21:37
@pllim pllim removed this from In progress in Dev Roadmap Feb 19, 2020
@pllim pllim merged commit 7d1b26a into spacetelescope:master Feb 19, 2020
@pllim pllim deleted the obs-spectrum1d-🌉 branch February 19, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eteq eteq Awaiting requested review from eteq

@nmearl nmearl Awaiting requested review from nmearl

Assignees
No one assigned
Labels
enhancement observation
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

Have synphot Observation be able to work directly on specutils.Spectrum1D
1 participant
@pllim