Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSX ARM64 wheel #352

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Add OSX ARM64 wheel #352

merged 2 commits into from
Mar 20, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 20, 2023

Description

This pull request is to add OSX ARM64 wheel to the release process. I decided not to switch to OpenAstronomy workflow. I already have something that works and I don't see much value right now to switch to something I cannot control.

Fixes #351

@pllim pllim added this to the 1.2.0 milestone Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 20, 2023

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2e9032f) 97.09% compared to head (7dab48d) 97.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files          17       17           
  Lines        2032     2032           
=======================================
  Hits         1973     1973           
  Misses         59       59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Use cibuildwheel action
and silence OSX ARM64 warning about wheel testing.
@pllim pllim merged commit c9016eb into spacetelescope:master Mar 20, 2023
@pllim pllim deleted the build-m1-wheel branch March 20, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish M1 wheels
1 participant