Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat with numpy 1.25 and doc compat with astropy v5.3 #356

Merged
merged 1 commit into from Jun 1, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 1, 2023

Description

This pull request fixes test failures with numpy 1.25 and astropy 5.3.

and doc compat with astropy v5.3.
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.30 ⚠️

Comparison is base (11db7cf) 97.09% compared to head (353832d) 96.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   97.09%   96.80%   -0.30%     
==========================================
  Files          17       17              
  Lines        2032     2032              
==========================================
- Hits         1973     1967       -6     
- Misses         59       65       +6     
Impacted Files Coverage Δ
synphot/utils.py 99.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim merged commit 8887b7f into spacetelescope:master Jun 1, 2023
21 of 22 checks passed
@pllim pllim deleted the fix-tst-astropy-v5.3 branch June 1, 2023 01:40
@pllim pllim modified the milestones: 1.3.0, 1.2.1 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant