Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: filter_par.rst result is from numpy<2 #375

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 12, 2024

Description

filter_par.rst result is from numpy<2 and needs to be updated when we run it with numpy>=2

Fixes #374

and needs to be updated when we run it with numpy>=2
Copy link

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d07fe2a) 96.80% compared to head (45ee8dd) 96.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          17       17           
  Lines        2034     2034           
=======================================
  Hits         1969     1969           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim marked this pull request as ready for review February 12, 2024 19:33
@pllim pllim merged commit f6ddfc5 into spacetelescope:master Feb 12, 2024
21 checks passed
@pllim pllim deleted the tynt-numpy-doctest branch February 12, 2024 19:33
@pllim pllim modified the milestones: 1.3.1, 1.4.0 Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: filter_par.rst doctest fails in devdeps
1 participant