Fixed trending histogram binning so that bars add up to 1.0 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI. Just for the sake of tracking. |
Merge Develop into PR
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #634 +/- ##
==========================================
Coverage ? 56.11%
==========================================
Files ? 14
Lines ? 6014
Branches ? 0
==========================================
Hits ? 3375
Misses ? 2639
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The histogram displayed by
trending.wfe_histogram_plotwas in fact a probability density function and, as a result, the sum of all the histogram bars was not 1.0 since the bin widths were not unity. This behavior is described in the Matplolib documentation. This PR enforces a bin width of 1 nm, which now allows the user to interpret each histogram bar as the fraction of measurements at a given WFE.Also includes other minor display convenience fixes.