Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying NIRCam LW detectors equivalently like 'NRCA5' or 'NRCALONG' #849

Merged
merged 1 commit into from
May 17, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented May 15, 2024

Issue #660 has been pending and slipped through the cracks, not dealt with for over a year now, about specifying NRCALONG as a synonym for NRCA5 and similarly for B. This is a quick easy fix so I just went ahead and fixed it for this release as well..

@mperrin mperrin self-assigned this May 15, 2024
@pep8speaks
Copy link

Hello @mperrin, Thank you for submitting the Pull Request !

Line 12:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file
Line 20:1: E402 module level import not at top of file
Line 22:1: E731 do not assign a lambda expression, use a def
Line 23:1: E731 do not assign a lambda expression, use a def
Line 24:1: E731 do not assign a lambda expression, use a def
Line 26:1: E731 do not assign a lambda expression, use a def
Line 30:1: E731 do not assign a lambda expression, use a def
Line 31:1: E731 do not assign a lambda expression, use a def
Line 180:126: E501 line too long (126 > 125 characters)
Line 199:5: E731 do not assign a lambda expression, use a def
Line 257:5: E731 do not assign a lambda expression, use a def
Line 314:126: E501 line too long (142 > 125 characters)
Line 398:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

Line 302:126: E501 line too long (148 > 125 characters)
Line 389:47: E114 indentation is not a multiple of four (comment)
Line 389:47: E116 unexpected indentation (comment)
Line 728:126: E501 line too long (152 > 125 characters)
Line 731:29: E201 whitespace after '('
Line 755:1: E266 too many leading '#' for block comment
Line 979:126: E501 line too long (133 > 125 characters)
Line 981:57: E225 missing whitespace around operator
Line 985:126: E501 line too long (165 > 125 characters)
Line 993:32: E201 whitespace after '('
Line 1005:126: E501 line too long (145 > 125 characters)
Line 1024:126: E501 line too long (134 > 125 characters)
Line 1042:82: E202 whitespace before ')'
Line 1083:52: E225 missing whitespace around operator
Line 1254:91: E231 missing whitespace after ','
Line 1254:126: E501 line too long (139 > 125 characters)
Line 1441:126: E501 line too long (200 > 125 characters)
Line 1597:126: E501 line too long (131 > 125 characters)
Line 1840:13: E731 do not assign a lambda expression, use a def
Line 1842:13: E731 do not assign a lambda expression, use a def
Line 1852:126: E501 line too long (165 > 125 characters)
Line 1875:9: E266 too many leading '#' for block comment
Line 1908:9: E266 too many leading '#' for block comment
Line 1909:9: E266 too many leading '#' for block comment
Line 1949:1: E302 expected 2 blank lines, found 1
Line 1953:5: E303 too many blank lines (2)
Line 1954:26: E201 whitespace after '('
Line 1968:5: E303 too many blank lines (2)
Line 2026:126: E501 line too long (127 > 125 characters)
Line 2051:126: E501 line too long (155 > 125 characters)
Line 2071:17: E126 continuation line over-indented for hanging indent
Line 2215:126: E501 line too long (141 > 125 characters)
Line 2357:36: E225 missing whitespace around operator
Line 2397:5: E303 too many blank lines (2)
Line 2416:5: E303 too many blank lines (2)
Line 2433:13: E265 block comment should start with '# '
Line 2436:13: E265 block comment should start with '# '
Line 2438:13: E265 block comment should start with '# '
Line 2439:13: E265 block comment should start with '# '
Line 2440:13: E265 block comment should start with '# '
Line 2441:9: E265 block comment should start with '# '
Line 2449:24: E225 missing whitespace around operator
Line 2453:65: E226 missing whitespace around arithmetic operator
Line 2610:126: E501 line too long (130 > 125 characters)
Line 2654:126: E501 line too long (130 > 125 characters)
Line 2664:126: E501 line too long (141 > 125 characters)
Line 2688:126: E501 line too long (130 > 125 characters)
Line 2714:31: E225 missing whitespace around operator
Line 3103:33: E116 unexpected indentation (comment)
Line 3134:33: E221 multiple spaces before operator
Line 3206:71: E231 missing whitespace after ','
Line 3207:126: E501 line too long (145 > 125 characters)
Line 3211:9: E303 too many blank lines (2)
Line 3220:5: E303 too many blank lines (2)
Line 3236:126: E501 line too long (139 > 125 characters)
Line 3251:126: E501 line too long (145 > 125 characters)
Line 3252:126: E501 line too long (137 > 125 characters)
Line 3265:126: E501 line too long (142 > 125 characters)
Line 3273:43: E261 at least two spaces before inline comment
Line 3276:5: E303 too many blank lines (2)
Line 3307:24: E225 missing whitespace around operator
Line 3329:5: E303 too many blank lines (2)

If you have not done so, please lint your code in accordance with best practices.

@mperrin mperrin changed the title fix issue #660 Allow specifying NIRCam LW detectors equivalently like 'NRCA5' or 'NRCALONG' May 15, 2024
@mperrin mperrin added this to the Release 1.3 milestone May 16, 2024
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@obi-wan76 obi-wan76 merged commit 6cf62b0 into spacetelescope:develop May 17, 2024
7 checks passed
@mperrin mperrin deleted the fix_660 branch May 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants