Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Compatibility with Ginga v4 #98

Draft
wants to merge 1 commit into
base: 98-ginga-v4-support
Choose a base branch
from

Conversation

pllim
Copy link
Collaborator

@pllim pllim commented Oct 10, 2022

Description

This pull request is to address compatibility issues with upcoming Ginga v4 release. This is a major release and includes some breaking changes.

Since I am handing this repository to @kulpster85 , he might have to take over this PR and finish it.

Blocked by

TODO

  • Find other incompatibilities and add their fixes here. Go through examples in https://wss-tools.readthedocs.io/en/latest/wss_tools/quip/index.html#using-quip and try out the custom plugins.
  • Make sure these fixes are backward-compatible with older Ginga that QUIP supports (e.g., you might need to check for Ginga version before picking which code to use). Alternatively, you can also bump minversion of supported Ginga in setup.cfg and not have to worry about backward compatibility.

If you decide to not ever use Ginga v4 (i.e., pin your maxversion to v3, then there is no need for this PR but you also will not get any new Ginga fixes or features).

@github-actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the 1.3 milestone Oct 10, 2022
@kulpster85 kulpster85 changed the base branch from master to 98-ginga-v4-support January 31, 2023 22:52
@kulpster85 kulpster85 changed the title MNT: Compatibility with Ginga v4 Compatibility with Ginga v4 Jan 31, 2023
@kulpster85 kulpster85 changed the title Compatibility with Ginga v4 MNT: Compatibility with Ginga v4 Jan 31, 2023
@kulpster85 kulpster85 mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants