Skip to content

Commit

Permalink
Fix check-notebooks makefile command; Add python 3.9 to slow-tests
Browse files Browse the repository at this point in the history
  • Loading branch information
njmei authored and ttung committed Oct 16, 2021
1 parent 2f9915a commit 4f6bc82
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 5 deletions.
33 changes: 29 additions & 4 deletions .github/workflows/starfish-prod-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
strategy:
matrix:
os: ["windows-latest", "ubuntu-latest"]
python-version: ["3.7", "3.8"]
python-version: ["3.7", "3.8", "3.9"]
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -357,6 +357,31 @@ jobs:
run: |
notebooks/py/SeqFISH.py
starmap-data-processing-example:
name: STARmap Notebook Test
needs: starfish-slow
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: Setpu Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.8

- uses: actions/cache@v2
with:
path: ${{ env.pythonLocation }}
key: ${{ runner.OS }}-${{ env.pythonLocation }}-${{ hashFiles('requirements/REQUIREMENTS-CI.txt') }}

- name: Install Dependencies
run: |
make install-dev
- name: Run Notebook Tests
run: |
make notebooks/py/STARmap.py
smfish-data-processing-example:
name: 3D smFISH Data Processing Example
needs: starfish-slow
Expand All @@ -378,7 +403,7 @@ jobs:
run: |
make install-dev
- name: Run Notebook Tests
- name: Run Data Processing Example Test
run: |
make 3d_smFISH.py
Expand All @@ -403,6 +428,6 @@ jobs:
run: |
make install-dev
- name: Run Notebook Tests
- name: Run Data Processing Example Test
run: |
make iss_pipeline.py
make TESTING=1 iss_pipeline.py
2 changes: 1 addition & 1 deletion notebooks/subdir.mk
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ $(py_files): %.py :
[ -e $*.py.skip ] || $(PYTHON) $*.py

$(py_check_targets): check__%.py :
grep -q $*.py .travis.yml
grep -q $*.py .github/workflows/starfish-prod-ci.yml

$(ipynb_validate_targets): TEMPFILE := $(shell mktemp)
$(ipynb_validate_targets): validate__notebooks/%.ipynb :
Expand Down

0 comments on commit 4f6bc82

Please sign in to comment.