Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pkcs8 format public key #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

liwmj
Copy link

@liwmj liwmj commented May 23, 2017

No description provided.

@spacewander
Copy link
Owner

@liwangmj
Could you explain why you want to do that?

@liwmj
Copy link
Author

liwmj commented May 23, 2017

@spacewander 直接生成成pkcs8格式的公钥,不用额外转换公钥,和java、php互通性更好。

@liwmj
Copy link
Author

liwmj commented May 23, 2017

@spacewander 经过实测,和ios、java、php秒通.

@spacewander
Copy link
Owner

@liwangmj
能否只在提供了额外的选项时才启用该功能?这样就不会破坏原有接口的兼容性了。
另外,新 feature 需要提供对应的单元测试。没有单元测试覆盖的功能,我们可不敢合并进来。

麻烦在 pr 里补下吧。

@spacewander spacewander changed the title Modify header format for: ---------- BEGIN PUBLIC KEY ---------- Support pkcs8 format public key May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants