Redesign with global filters #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will get rid of unecessary links, add a mono font and add some top-level template structure.
|
Wow Daisy is gorgeous! Could you either add padding to the button, or shorten to just View? It looks a little cramped as is:
Aside from that, it's super nice! Are you going to squash the commits (there are quite a lot!) |
…e.spack.io into design-revisions # Conflicts: # _layouts/home.html # assets/css/style.css # tailwind.css
Begin home style improvements
|
The button should be fixed. I agree things are getting a bit unwieldy, if you wouldn't mind using the "Merge with squash" feature I'd appreciate it. I'd like to get this merged as is even though there are a few flaws so future work can be incremental and easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #3 with additional changes, most notably swapping out bootstrap for DaisyUI and adding global build cache and stack filtering.
Changes can be previewed here: https://danlamanna.github.io/cache.spack.io/.