Use spack to install gpg 2.4 for amazon-linux-2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haampie
reviewed
Mar 8, 2023
haampie
reviewed
Mar 8, 2023
haampie
reviewed
Mar 8, 2023
haampie
reviewed
Mar 8, 2023
haampie
reviewed
Mar 8, 2023
|
Thanks for the feedback @haampie . I'm testing out your proposed changes locally. If all goes well I'll push an update shortly. |
zackgalbreath
force-pushed
the
update_gpg_on_amazon_linux
branch
from
a0d3172
to
6b72be4
Compare
haampie
reviewed
Mar 8, 2023
Co-authored-by: eugeneswalker <38933153+eugeneswalker@users.noreply.github.com> Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
zackgalbreath
force-pushed
the
update_gpg_on_amazon_linux
branch
from
b34ebac
to
18f6234
Compare
haampie
reviewed
Mar 9, 2023
|
Bit confused about SPACK_ROOT... should really not be necessary |
me too 😅 but I was following what CI told me to do here: https://github.com/spack/gitlab-runners/actions/runs/4369563677/jobs/7643487182#step:7:3084 |
haampie
approved these changes
Mar 9, 2023
|
Apparently CI is not a requirement to merge things here, lol. In any case, if it builds on the main branch that saves some CPU cycles |
|
You don't have to set up shell support to use spack, so that simplifies things. The problem is that /proc/1/exe symlinks to the host system's qemu, not the docker image's shell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.