Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start with cursor in search box #19

Merged
merged 2 commits into from
May 6, 2024
Merged

start with cursor in search box #19

merged 2 commits into from
May 6, 2024

Conversation

jsta
Copy link
Contributor

@jsta jsta commented May 2, 2024

This PR makes it so when you navigate to the page with the search box, your cursor starts in the box ready to go.

@vsoch
Copy link
Member

vsoch commented May 2, 2024

This is a great idea! Quick question, what is the difference between:

<input autofocus="autofocus"></input>

(in this PR) vs what I see here

<input autofocus></input>

@jsta
Copy link
Contributor Author

jsta commented May 2, 2024

Possibly nothing? At least no difference I see in practice either way. I'll revise to be more canonical.

Copy link
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - one nit might be to still be consistent with spacing, but it doesn't change functionality of the site.

Let's wait for another reviewer that is actively maintaining the site.

Thanks for this @jsta!

@danlamanna danlamanna merged commit 1ea6650 into spack:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants