Configure staging cluster using Kustomize #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
changed the title
jjnesbitt
reviewed
Mar 6, 2023
There was a problem hiding this comment.
This all makes sense and looks good to me, but I'm somewhat hesitant to say I approve, mainly because there's just a lot of changes here, and even ignoring the moved files, something could easily slip through the cracks. Do you see any reasonable way to test this?
mvandenburgh
force-pushed
the
kustomize
branch
2 times, most recently
from
622af59
to
e062e11
Compare
mvandenburgh
force-pushed
the
kustomize
branch
7 times, most recently
from
15637af
to
66b1543
Compare
mvandenburgh
force-pushed
the
kustomize
branch
6 times, most recently
from
7bef3f4
to
b36f062
Compare
mvandenburgh
force-pushed
the
kustomize
branch
4 times, most recently
from
d931159
to
a7b3de1
Compare
mvandenburgh
force-pushed
the
kustomize
branch
10 times, most recently
from
0ec5892
to
57c07d4
Compare
jjnesbitt
reviewed
Apr 18, 2023
jjnesbitt
reviewed
Apr 18, 2023
jjnesbitt
previously approved these changes
Apr 18, 2023
jjnesbitt
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't applied the terraform changes to production yet; since we're making a change to the Flux config, it will require extra care so that we don't disrupt anything. I have applied the terraform changes to staging though, and the Kustomizations work as intended.
Some extra care needs to be taken when merging this, since we're touching the Flux configuration. Steps that need to be taken to apply this:
*-controllerpods in order for the changes to take effect.