signing script: Do not fail when there is nothing to sign #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the globbing pattern seems to produce an empty match when there are no spec files in the working directory. Replacing the glob with the results of find prevents entering the loop unless there are any actual files in the directory. Normally if there was nothing to rebuild, we would not schedule this job anyway. So this is guarding an exceptional case, where all the scheduled rebuild jobs failed, something we saw when the version of gpg in one of the rebuild images was incompatible with one of the intermediate signing keys.
6 tasks
|
Testing this is tricky since |
zackgalbreath
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the globbing pattern seems to produce an empty match when there are no spec files in the working directory. Replacing the glob with the results of find prevents entering the loop unless there are any actual files in the directory.
Normally if there was nothing to rebuild, we would not schedule this job anyway. So this is guarding an exceptional case, where all the scheduled rebuild jobs failed, something we saw when the version of gpg in one of the rebuild images was incompatible with one of the intermediate signing keys.